From 6825b189c5e07af742a10ea69d6cd41abde35c34 Mon Sep 17 00:00:00 2001 From: Krist Wongsuphasawat Date: Wed, 20 Mar 2019 13:34:08 -0700 Subject: [PATCH] fix: address comments --- packages/superset-ui-preset-chart-xy/package.json | 1 - .../src/encodeable/types/FieldDef.ts | 2 -- 2 files changed, 3 deletions(-) diff --git a/packages/superset-ui-preset-chart-xy/package.json b/packages/superset-ui-preset-chart-xy/package.json index 29b1ed707..e7f08ae83 100644 --- a/packages/superset-ui-preset-chart-xy/package.json +++ b/packages/superset-ui-preset-chart-xy/package.json @@ -42,7 +42,6 @@ "lodash": "^4.17.11", "prop-types": "^15.6.2", "reselect" : "^4.0.0", - "vega": "^5.2.0", "vega-lite": "^3.0.0-rc15" }, "peerDependencies": { diff --git a/packages/superset-ui-preset-chart-xy/src/encodeable/types/FieldDef.ts b/packages/superset-ui-preset-chart-xy/src/encodeable/types/FieldDef.ts index ec47947b7..7cce9f7fa 100644 --- a/packages/superset-ui-preset-chart-xy/src/encodeable/types/FieldDef.ts +++ b/packages/superset-ui-preset-chart-xy/src/encodeable/types/FieldDef.ts @@ -11,8 +11,6 @@ export type Formatter = NumberFormatter | TimeFormatter | ((d: any) => string); // ValueDef is { value: xxx } -// FieldDef is { field: 'fieldName', type: ... } - export interface FieldDef { field: string; format?: string;