This repository has been archived by the owner on Jun 25, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 77
fix: horizon chart should scroll when overflowing #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52dc2e3
to
09989f5
Compare
Deploy preview for superset-ui-plugins ready! Built with commit 52dc2e3 |
Deploy preview for superset-ui-plugins ready! Built with commit 06aa63a |
ci shows lint error. |
09989f5
to
2bae2b1
Compare
b0ad1d1
to
ae2f648
Compare
The build is failing. |
2d143ac
to
be4951b
Compare
be4951b
to
9717dc7
Compare
12 tasks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine, but the problem in the build seems unrelated.
9717dc7
to
2fb6d6e
Compare
Codecov Report
@@ Coverage Diff @@
## master #180 +/- ##
=======================================
Coverage 37.99% 37.99%
=======================================
Files 12 12
Lines 229 229
Branches 21 21
=======================================
Hits 87 87
Misses 132 132
Partials 10 10 Continue to review full report at Codecov.
|
kristw
approved these changes
Nov 20, 2019
nytai
pushed a commit
to preset-io/superset-ui-plugins
that referenced
this pull request
Apr 27, 2020
…et#180) * feat: store reference to container * fix: minor adjustment * feat: forward ref from shell to superchart
nytai
pushed a commit
to preset-io/superset-ui-plugins
that referenced
this pull request
Apr 27, 2020
…erflowing (apache-superset#180) * fix: horizon chart should scroll when overflowing * fix: rebase and adapt * fix: lint
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💔 Breaking Changes
🏆 Enhancements
📜 Documentation
🐛 Bug Fix
🏠 Internal