Skip to content
This repository has been archived by the owner on Jun 25, 2020. It is now read-only.

fix: horizon chart should scroll when overflowing #180

Merged
merged 3 commits into from
Nov 20, 2019

Conversation

mistercrunch
Copy link
Contributor

💔 Breaking Changes

🏆 Enhancements

📜 Documentation

🐛 Bug Fix

🏠 Internal

@mistercrunch mistercrunch requested a review from a team as a code owner August 19, 2019 00:33
@netlify
Copy link

netlify bot commented Aug 19, 2019

Deploy preview for superset-ui-plugins ready!

Built with commit 52dc2e3

https://deploy-preview-180--superset-ui-plugins.netlify.com

@netlify
Copy link

netlify bot commented Aug 19, 2019

Deploy preview for superset-ui-plugins ready!

Built with commit 06aa63a

https://deploy-preview-180--superset-ui-plugins.netlify.com

@kristw
Copy link
Collaborator

kristw commented Aug 22, 2019

ci shows lint error.

@mistercrunch mistercrunch force-pushed the fix_horizon_overflow branch 2 times, most recently from b0ad1d1 to ae2f648 Compare September 13, 2019 20:30
@kristw
Copy link
Collaborator

kristw commented Sep 13, 2019

The build is failing.

@mistercrunch mistercrunch force-pushed the fix_horizon_overflow branch 2 times, most recently from 2d143ac to be4951b Compare September 14, 2019 20:10
Copy link

@MarcusSorealheis MarcusSorealheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine, but the problem in the build seems unrelated.

@kristw kristw force-pushed the fix_horizon_overflow branch from 9717dc7 to 2fb6d6e Compare November 19, 2019 07:55
@codecov
Copy link

codecov bot commented Nov 20, 2019

Codecov Report

Merging #180 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #180   +/-   ##
=======================================
  Coverage   37.99%   37.99%           
=======================================
  Files          12       12           
  Lines         229      229           
  Branches       21       21           
=======================================
  Hits           87       87           
  Misses        132      132           
  Partials       10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fded8a...06aa63a. Read the comment docs.

@kristw kristw merged commit 8a5e84a into master Nov 20, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix_horizon_overflow branch November 20, 2019 00:56
nytai pushed a commit to preset-io/superset-ui-plugins that referenced this pull request Apr 27, 2020
…et#180)

* feat: store reference to container

* fix: minor adjustment

* feat: forward ref from shell to superchart
nytai pushed a commit to preset-io/superset-ui-plugins that referenced this pull request Apr 27, 2020
…erflowing (apache-superset#180)

* fix: horizon chart should scroll when overflowing

* fix: rebase and adapt

* fix: lint
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants