This repository has been archived by the owner on Jun 25, 2020. It is now read-only.
fix(tablevis): Set proper width for each column #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #189 +/- ##
=======================================
Coverage 34.25% 34.25%
=======================================
Files 12 12
Lines 216 216
Branches 21 21
=======================================
Hits 74 74
Misses 132 132
Partials 10 10Continue to review full report at Codecov.
|
|
Deploy preview for superset-ui-plugins ready! Built with commit 6ea8272 |
kristw
reviewed
Sep 4, 2019
packages/superset-ui-plugins-demo/storybook/stories/plugin-chart-table/bigData.js
Outdated
Show resolved
Hide resolved
kristw
approved these changes
Sep 4, 2019
nytai
pushed a commit
to preset-io/superset-ui-plugins
that referenced
this pull request
Apr 27, 2020
* fix(tablevis): set the width for each column n * fix(fix comments): fix comments from pr * fix(revert to charwidth): revert to charwidth
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💔 Breaking Changes
🏆 Enhancements
📜 Documentation
🐛 Bug Fix
This PR is to fix the issue of the readability of table vis when there are too many columns in the table.
Before rendering the table, we will estimate the width for each column according to the max string length (max width is set to be 500px).
🏠 Internal