This repository has been archived by the owner on Jun 25, 2020. It is now read-only.
fix: make pivot table handle null string #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @kristw, apache/superset#4905 appreciates it. |
nytai
referenced
this pull request
in preset-io/superset-ui-plugins
Apr 27, 2020
…#23) * initialize chart package * add unit tests for metadata and chartprops * fix lint * add unit test for ChartPlugin * update README
nytai
referenced
this pull request
in preset-io/superset-ui-plugins
Apr 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Bug Fix
'null'string and do not try to format it asNaNBefore
After
related to: apache/superset#4905
cc: @john-bodley