Skip to content
This repository has been archived by the owner on Jun 25, 2020. It is now read-only.

feat: improve table performance #246

Merged
merged 7 commits into from
Nov 12, 2019
Merged

feat: improve table performance #246

merged 7 commits into from
Nov 12, 2019

Conversation

kristw
Copy link
Collaborator

@kristw kristw commented Nov 5, 2019

🏆 Enhancements

  • reduce computation within renderer
  • more memoization
  • only dompurity.sanitize() non-metric cells.

@kristw kristw requested a review from a team as a code owner November 5, 2019 10:06
@netlify
Copy link

netlify bot commented Nov 5, 2019

Deploy preview for superset-ui-plugins ready!

Built with commit ba52715

https://deploy-preview-246--superset-ui-plugins.netlify.com

@codecov
Copy link

codecov bot commented Nov 5, 2019

Codecov Report

Merging #246 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #246   +/-   ##
=======================================
  Coverage   37.99%   37.99%           
=======================================
  Files          12       12           
  Lines         229      229           
  Branches       21       21           
=======================================
  Hits           87       87           
  Misses        132      132           
  Partials       10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a69b859...ba52715. Read the comment docs.

@ghost
Copy link

ghost commented Nov 11, 2019

There were the following issues with this Pull Request

  • Commit: ba52715
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@kristw kristw merged commit bc46902 into master Nov 12, 2019
@delete-merged-branch delete-merged-branch bot deleted the kristw--opti branch November 12, 2019 22:14
nytai pushed a commit to preset-io/superset-ui-plugins that referenced this pull request Apr 27, 2020
nytai pushed a commit to preset-io/superset-ui-plugins that referenced this pull request Apr 27, 2020
* feat: optimize table rendering

* fix: memoize

* fix: more opti

* fix: bug

* fix: render 0

* fix: return type

* Update HTMLRenderer.tsx
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant