This repository has been archived by the owner on Jun 25, 2020. It is now read-only.
fix(table): fix sorting, column width calculation, and text wrapping #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #253 +/- ##
=======================================
Coverage 37.99% 37.99%
=======================================
Files 12 12
Lines 229 229
Branches 21 21
=======================================
Hits 87 87
Misses 132 132
Partials 10 10Continue to review full report at Codecov.
|
kristw
reviewed
Nov 12, 2019
| function getText(value: unknown, format: TimeFormatter | NumberFormatter | undefined) { | ||
| let formattedValue = value; | ||
| if (format) { | ||
| formattedValue = format.format(value as any); |
There was a problem hiding this comment.
Should we return here? If there is a format function, that should not produce html output.
kristw
reviewed
Nov 12, 2019
| let formattedValue = value; | ||
| if (format) { | ||
| formattedValue = format.format(value as any); | ||
| } | ||
| if (typeof value === 'string') { | ||
| const span = document.createElement('span'); |
There was a problem hiding this comment.
Another new trick I learn is using regex to remove all html tags.
I think it should be faster than parsing html via span tag, although haven't really tested it.
const htmlTagRegex = /(<([^>]+)>)/gi;
const text = value.replace(htmlTagRegex, '');
kristw
approved these changes
Nov 12, 2019
|
Deploy preview for superset-ui-plugins ready! Built with commit 403dbf8 |
12 tasks
nytai
pushed a commit
to preset-io/superset-ui-plugins
that referenced
this pull request
Apr 27, 2020
…erset#253) Bumps [@types/lodash](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/lodash) from 4.14.108 to 4.14.147. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/lodash) Signed-off-by: dependabot-preview[bot] <[email protected]>
nytai
pushed a commit
to preset-io/superset-ui-plugins
that referenced
this pull request
Apr 27, 2020
…pache-superset#253) * fix(table): fix issues * fix(table): fix comments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💔 Breaking Changes
🏆 Enhancements
📜 Documentation
🐛 Bug Fix
This PR is to
better calculation of the column width (with formatted string);
lexicographically sorting strings;
fixing word truncating issues;
🏠 Internal
cc: @etr2460 @graceguo-supercat