This repository has been archived by the owner on Jun 25, 2020. It is now read-only.
fix: line chart does not handle temporal field correctly #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for superset-ui-plugins ready! Built with commit 0b03011 |
|
Deploy preview for superset-ui-plugins ready! Built with commit 3395153 |
nytai
pushed a commit
to preset-io/superset-ui-plugins
that referenced
this pull request
Apr 27, 2020
* Add superchart and convert to ts * fix compilation error * fix build issue * unit test working * Add default width and height to ChartProps * export SuperChart * Add null check and update unit tests * update unit tests * complete test coverage * Add generic * reduce timeout
nytai
pushed a commit
to preset-io/superset-ui-plugins
that referenced
this pull request
Apr 27, 2020
…rset#68) * fix: fallback to default margin when margin is partially set * feat: can disable axis title * feat: adjust margin according to axis title visibility * feat: include margin in formData * feat: add buildQuery * fix: address kyle comments * fix: remove string false * fix: line chart temporal scale * fix: format
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Bug Fix
The Line Chart is using
@data-ui/xy-chartunder the hood which takes care of scaling by itself at the moment. The previous code already encode the data from time into position before passing to@data-ui/xy-chartso it did not render correctly.