This repository has been archived by the owner on Jun 25, 2020. It is now read-only.
feat: make line chart query operate in time series mode #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for superset-ui-plugins ready! Built with commit 5cf22f5 |
kristw
changed the title
conglei
reviewed
Apr 24, 2019
|
|
||
| // Enforce time-series mode | ||
| queryContext.queries.forEach(query => { | ||
| const q = query; |
There was a problem hiding this comment.
nit: Should we make a copy? (I don't think it is necessary imo).
There was a problem hiding this comment.
umm good point. but since nobody has access to the original one I think it is ok to modify instead of cloning the entire queryContext.
nytai
pushed a commit
to preset-io/superset-ui-plugins
that referenced
this pull request
Apr 27, 2020
…ion) (apache-superset#71) * Handle BigNumber conversions in JSON properly (without loss of precision) * Rewrap "errors" from JSONbig.parse in proper error object. * Use DefinitelyTyped's fetch-mock type def * Improved type def for json-bigint * Added type casts to some tests due to addition of fetchMock type def
nytai
pushed a commit
to preset-io/superset-ui-plugins
that referenced
this pull request
Apr 27, 2020
…f precision) (apache-superset#71)" (apache-superset#126) * revert: revert "Handle BigNumber conversions in JSON properly (without loss of precision) (apache-superset#71)" This reverts commit e386612. * fix: type errors * fix: typescript errors in superset-ui-demo
nytai
pushed a commit
to preset-io/superset-ui-plugins
that referenced
this pull request
Apr 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Bug Fix
To ensure the output is grouped by time for time series.
@conglei