Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use common technique in monitor code to rate limit refreshing data #4885

Open
keith-turner opened this issue Sep 13, 2024 · 0 comments · May be fixed by #4894
Open

Use common technique in monitor code to rate limit refreshing data #4885

keith-turner opened this issue Sep 13, 2024 · 0 comments · May be fixed by #4894
Assignees
@DomGarguilo
Labels
enhancement This issue describes a new feature, improvement, or optimization.
Milestone
2.1.4

Comments

@keith-turner
Copy link
Contributor

keith-turner commented Sep 13, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.

The monitor has a pattern of only fetching data from other severs in the system periodically. The actual code for implementing this common pattern differs.

Describe the solution you'd like

In #4867 this was done using Suppliers.memoize for external compactions. In #4867 it was suggested that other code in the monitor could use Suppliers.memoize or possibly a guava cache.
@keith-turner keith-turner added the enhancement This issue describes a new feature, improvement, or optimization. label Sep 13, 2024
@keith-turner keith-turner mentioned this issue Sep 13, 2024
Merged
@DomGarguilo DomGarguilo self-assigned this Sep 17, 2024
@DomGarguilo DomGarguilo added this to the 2.1.4 milestone Sep 17, 2024
@DomGarguilo DomGarguilo linked a pull request Sep 17, 2024 that will close this issue
Improve/standardize rate limiting logic in Monitor #4894
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DomGarguilo DomGarguilo

Labels
enhancement This issue describes a new feature, improvement, or optimization.
Projects
None yet
Milestone
2.1.4
Development

Successfully merging a pull request may close this issue.

Improve/standardize rate limiting logic in Monitor DomGarguilo/accumulo
2 participants
@keith-turner @DomGarguilo