Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task_id with . e.g. hello.world is not rendered in grid view #23580

Closed
1 of 2 tasks
eduardchai opened this issue May 9, 2022 · 3 comments · Fixed by #23590
Closed
1 of 2 tasks

task_id with . e.g. hello.world is not rendered in grid view #23580

eduardchai opened this issue May 9, 2022 · 3 comments · Fixed by #23590
Labels
area:UI Related to UI/UX. For Frontend Developers. kind:bug This is a clearly a bug

Comments

@eduardchai
Copy link

Apache Airflow version

2.3.0 (latest released)

What happened

task_id with . e.g. hello.world is not rendered in grid view.

What you think should happen instead

The task should be rendered just fine in Grid view.

How to reproduce

#
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements.  See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership.  The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License.  You may obtain a copy of the License at
#
#   http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied.  See the License for the
# specific language governing permissions and limitations
# under the License.

"""Example DAG demonstrating the usage of the BashOperator."""

from datetime import datetime, timedelta

from airflow import DAG
from airflow.operators.bash import BashOperator
from airflow.operators.dummy import DummyOperator

with DAG(
    dag_id="example_bash_operator",
    schedule_interval="0 0 * * *",
    start_date=datetime(2021, 1, 1),
    catchup=False,
    dagrun_timeout=timedelta(minutes=60),
    tags=["example", "example2"],
    params={"example_key": "example_value"},
) as dag:
    run_this_last = DummyOperator(
        task_id="run.this.last",
    )

    # [START howto_operator_bash]
    run_this = BashOperator(
        task_id="run.after.loop",
        bash_command="echo 1",
    )
    # [END howto_operator_bash]

    run_this >> run_this_last

    for i in range(3):
        task = BashOperator(
            task_id="runme." + str(i),
            bash_command='echo "{{ task_instance_key_str }}" && sleep 1',
        )
        task >> run_this

    # [START howto_operator_bash_template]
    also_run_this = BashOperator(
        task_id="also.run.this",
        bash_command='echo "run_id={{ run_id }} | dag_run={{ dag_run }}"',
    )
    # [END howto_operator_bash_template]
    also_run_this >> run_this_last

# [START howto_operator_bash_skip]
this_will_skip = BashOperator(
    task_id="this.will.skip",
    bash_command='echo "hello world"; exit 99;',
    dag=dag,
)
# [END howto_operator_bash_skip]
this_will_skip >> run_this_last

if __name__ == "__main__":
    dag.cli()

Operating System

Debian GNU/Linux 11 (bullseye)

Versions of Apache Airflow Providers

No response

Deployment

Official Apache Airflow Helm Chart

Deployment details

No response

Anything else

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@eduardchai eduardchai added area:core kind:bug This is a clearly a bug labels May 9, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented May 9, 2022

Thanks for opening your first issue here! Be sure to follow the issue template!

@tirkarthi
Copy link
Contributor

cc: @bbovenzi I guess this has something to do with task_id having dot used to render in splitting task_id by dot :

const parentTasks = task.id.split('.');

@bbovenzi bbovenzi added area:UI Related to UI/UX. For Frontend Developers. and removed area:core labels May 9, 2022
@bbovenzi
Copy link
Contributor

bbovenzi commented May 9, 2022

Oh good catch. We can parse out the names differently to avoid this problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. kind:bug This is a clearly a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants