Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix changing the parent dag state on subdag clear #15562

Merged
merged 3 commits into from
Apr 30, 2021

Conversation

zarrarrana
Copy link
Contributor

Closes: #15374
This pull request follows #14776.

Clearing a subdag with Downstream+Recursive does not automatically set the state of the parent dag so that the downstream parent tasks can execute.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg
Copy link

boring-cyborg bot commented Apr 28, 2021

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, pylint and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@xinbinhuang xinbinhuang self-requested a review April 28, 2021 06:45
@zarrarrana
Copy link
Contributor Author

@ashb @kaxil @turbaszek @XD-DENG
Can someone please approve the CI workflow?

@kaxil
Copy link
Member

kaxil commented Apr 29, 2021

Done

@zarrarrana
Copy link
Contributor Author

@ashb @kaxil please review.

@zarrarrana zarrarrana closed this Apr 29, 2021
@zarrarrana zarrarrana reopened this Apr 29, 2021
@zarrarrana
Copy link
Contributor Author

@kaxil @ashb
I accidently closed the PR, could you approve the CI workflow again.

@kaxil kaxil requested a review from ephraimbuddy April 29, 2021 22:49
@kaxil kaxil added this to the Airflow 2.0.3 milestone Apr 29, 2021
@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Apr 29, 2021
@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@zarrarrana
Copy link
Contributor Author

Hi @kaxil do you know what the next step is, it still says 1 workflow awaiting approval?

@kaxil kaxil merged commit a4211e2 into apache:master Apr 30, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Apr 30, 2021

Awesome work, congrats on your first merged pull request!

potiuk pushed a commit that referenced this pull request May 9, 2021
Closes: #15374
This pull request follows #14776.

Clearing a subdag with Downstream+Recursive does not automatically set the state of the parent dag so that the downstream parent tasks can execute.

(cherry picked from commit a4211e2)
@ashb ashb modified the milestones: Airflow 2.0.3, Airflow 2.1 May 18, 2021
@yuqian90
Copy link
Contributor

This PR fixed some issues but isn't a complete fix (there are other ways the cleared TaskInstance can involve multiple DAGs. See Cross-DAG Dependencies). I put up another PR some time ago which should fix the remaining issues as well as the issue this PR reported: #15382

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
full tests needed We need to run full set of tests for this PR to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clearing a subdag task leaves parent dag in the failed state
4 participants