Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mssql db check before starting tests #16134

Merged
merged 3 commits into from
May 28, 2021

Conversation

aneesh-joseph
Copy link
Contributor

Add MSSQL DB check before stating the tests


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label May 28, 2021
Copy link
Member

@mik-laj mik-laj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add this check also to the docker-compose file. entrypoint.sh is an extra sanity check only.
See:
#13446

In 'scripts/ci/docker-compose/backend-mssql.yml', we should update the depends_on section as follow:

   airflow:
    depends_on:
      mssql:
        condition: service_healthy

See example:
'scripts/ci/docker-compose/backend-mysql.yml'

Ps. This feature is not documented in docker docs, but it wokrs. See: #15509

@aneesh-joseph aneesh-joseph requested a review from mik-laj May 28, 2021 10:45
@potiuk
Copy link
Member

potiuk commented May 28, 2021

Ps. This feature is not documented in docker docs, but it wokrs. See: #15509

Lovely :)

@potiuk potiuk merged commit a7e1f7a into apache:master May 28, 2021
@aneesh-joseph aneesh-joseph deleted the add-mssql-db-wait branch May 28, 2021 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dev-tools full tests needed We need to run full set of tests for this PR to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants