Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: create route with plugin, will be error #1035

Closed
idbeta opened this issue Dec 12, 2020 · 1 comment
Closed

bug: create route with plugin, will be error #1035

idbeta opened this issue Dec 12, 2020 · 1 comment

Comments

@idbeta
Copy link
Contributor

idbeta commented Dec 12, 2020

Bug report

Describe the bug

create route with plugin, will be error

How to Reproduce

  1. create route with route, only enable the plugin but not do any config, so when finish commit the route, it will prompt an error, which is correct
    image
{"name":"test","desc":"","uris":["/name"],"methods":["GET","HEAD","POST","PUT","DELETE","OPTIONS","PATCH"],"priority":0,"plugins":{"limit-count":{"disable":false,"policy":"local","rejected_code":503}},"vars":[],"upstream":{"type":"roundrobin","timeout":{"connect":6000,"send":6000,"read":6000},"nodes":[{"host":"127.0.0.1","port":80,"weight":1}]}}
  1. but when I go back to route config, and disable the plugin, when finish commit the route again, it also will prompt an error, which is wrong
{"name":"test","desc":"","uris":["/name"],"methods":["GET","HEAD","POST","PUT","DELETE","OPTIONS","PATCH"],"priority":0,"plugins":{"limit-count":{"disable":true,"policy":"local","rejected_code":503}},"vars":[],"upstream":{"type":"roundrobin","timeout":{"connect":6000,"send":6000,"read":6000},"nodes":[{"host":"127.0.0.1","port":80,"weight":1}]}}
@idbeta idbeta added the bug Something isn't working label Dec 12, 2020
@juzhiyuan juzhiyuan added backend discuss frontend plugin and removed bug Something isn't working labels Dec 12, 2020
@juzhiyuan
Copy link
Member

Need a discussion on if we MUST have valid data no matter enable or disable that plugin.

cc @nic-chen @idbeta @membphis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants