Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve testing coverage for the POST and PATCH methods of the resources #1332

Closed
imjoey opened this issue Jan 19, 2021 · 7 comments
Closed
Assignees
Milestone

Comments

@imjoey
Copy link
Member

imjoey commented Jan 19, 2021

Feature request

Please describe your feature

At present, most test cases in Backend E2E and Unit-test cases are using PUT method for creating and updating the resource, which leads to extremely low testing coverage for creating by POST and updating by PATCH.

Describe the solution you'd like

So it would be much better that if we could add more test cases for the POST and PATCH methods of the resource. Of course, I would say adding missing test cases is heavy work, so let us fix this gradually.

@starsz
Copy link
Contributor

starsz commented Jan 20, 2021

Aha! Much appreciated.

@Jaycean
Copy link
Member

Jaycean commented Jan 29, 2021

I hope to help add more test cases.

@juzhiyuan
Copy link
Member

@Jaycean Assign to you! Thanks a lot!

@imjoey
Copy link
Member Author

imjoey commented Jan 29, 2021

I hope to help add more test cases.

@Jaycean thanks a lot. 😄

@Jaycean
Copy link
Member

Jaycean commented Feb 5, 2021

issue: #1161
Planned unit test refactoring of ssl,route,upstream,service.
Unit testing of the patch method will be added.

@juzhiyuan juzhiyuan added this to the 2.5 milestone Feb 7, 2021
@nic-chen
Copy link
Member

@Jaycean could we close this issue now ?

@Jaycean
Copy link
Member

Jaycean commented Mar 15, 2021

@Jaycean could we close this issue now ?

The issue is closed and the test case is complete. If there is any problem, open it again.

@Jaycean Jaycean closed this as completed Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants