Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: supports dynamic configuration of stream-route #1986

Closed
tzssangglass opened this issue Jul 17, 2021 · 11 comments · Fixed by #2104
Closed

feat: supports dynamic configuration of stream-route #1986

tzssangglass opened this issue Jul 17, 2021 · 11 comments · Fixed by #2104
Assignees
Labels

Comments

@tzssangglass
Copy link
Member

Feature request

Please describe your feature

dashboard supports dynamic configuration of stream-route, just like configuring route.

Describe the solution you'd like

we can add a stream-route button on the left side, just like
image

Additional context

the APISIX's admin-api of stream-route: https://github.com/apache/apisix/blob/master/docs/en/latest/admin-api.md#stream-route

the stream-proxy of APISIX: https://github.com/apache/apisix/blob/master/docs/en/latest/stream-proxy.md

I'm still working on the idea for this, any good suggestions from the community?

@liuxiran
Copy link
Contributor

Agree with @tzssangglass suggestion, add the menu item Stream Route after Route would be better, and for create/configure the Stream Route, we can consider follow the way Route does.

And in fact it is a complete module, we need both UI and manager-api,

for UI:

  • add menu item Stream Route and List page
  • Create Stream Route
  • Configure Stream Route
  • Delete Stream Route

for manager-api

refer to https://apisix.apache.org/docs/apisix/2.7/admin-api#request-methods-10

welcome prs to support this feature in the dashboard.

@Baoyuantop
Copy link
Contributor

Hi @liuxiran, I would like to try the UI part.

@liuxiran liuxiran assigned Baoyuantop and unassigned LiteSun Aug 24, 2021
@liuxiran
Copy link
Contributor

Hi @liuxiran, I would like to try the UI part.

thanks a lot @Baoyuantop , assign to you~

@liuxiran
Copy link
Contributor

who would like to try the part of manger-api, @Xu-Mj do you like to try it?

@Xu-Mj
Copy link
Contributor

Xu-Mj commented Aug 24, 2021

who would like to try the part of manger-api, @Xu-Mj do you like to try it?

ok , i'll try this part.

@liuxiran
Copy link
Contributor

who would like to try the part of manger-api, @Xu-Mj do you like to try it?

ok , i'll try this part.

cool~ thanks @Xu-Mj , please comment here when you have any questions

@liuxiran
Copy link
Contributor

Hi @liuxiran, I would like to try the UI part.

thanks a lot @Baoyuantop , assign to you~

Hi @Baoyuantop I noticed that @Xu-Mj has submitted #2104 for the API part, you can have a try with your UI part, and any problems can comment here, thanks a lot

@liuxiran liuxiran modified the milestones: 2.7.2, 2.9 Aug 31, 2021
@liuxiran
Copy link
Contributor

in order to let dashboard work together with APISIX 2.9, we adjusted our plan to quickly release a suitable version, and for this missing feature, move it to m2.9, and hope for this big feature ready, any questions can comment here, thanks a lot

@liuxiran
Copy link
Contributor

liuxiran commented Sep 9, 2021

Hi @Baoyuantop do you need any help with the front-end functionality?

@Baoyuantop
Copy link
Contributor

Hi @Baoyuantop do you need any help with the front-end functionality?

I'm doing it, not yet

@bzp2010 bzp2010 removed this from the 2.9.1 milestone Oct 11, 2021
@caibirdme
Copy link

any update for this feature?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants