Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: after enable redirect HTTPS, websocket form field disappeared #2087

Closed
bingoku opened this issue Aug 24, 2021 · 9 comments · Fixed by #2115
Closed

Bug: after enable redirect HTTPS, websocket form field disappeared #2087

bingoku opened this issue Aug 24, 2021 · 9 comments · Fixed by #2115
Assignees
Labels
bug Something isn't working
Milestone

Comments

@bingoku
Copy link

bingoku commented Aug 24, 2021

Issue description

image

Expected behavior

开启 HTTPS 后能显示 websocket 按钮进行操作

How to Reproduce

稳定复现

Screenshots

No response

Environment

  • apisix version (cmd: apisix version):
  • OS (cmd: uname -a):
  • OpenResty / Nginx version (cmd: nginx -V or openresty -V):
  • etcd version, if have (cmd: run etcd --version):
  • apisix-dashboard version, if have:
  • Browser version, if have:

Additional context

No response

@bingoku bingoku added the bug Something isn't working label Aug 24, 2021
@liuxiran
Copy link
Contributor

Hi @bingoku , see here to learn more: #1933 (comment)

so may I ask what your actual needs are for this operation? Then we can recommend a suitable operating procedure, thanks

@bingoku
Copy link
Author

bingoku commented Aug 25, 2021

其实就是想这个 UI 能发挥自身的作用,个别功能是缺失的。
上述这个问题是,开启重定向后,依然可以选择 继续开启 websocket 是需求。

@liuxiran liuxiran changed the title 路由开启 HTTPS 后 websocket 按钮消失。 Bug: after enable redirect HTTPS, websocket form field disappeared Aug 25, 2021
@liuxiran
Copy link
Contributor

上述这个问题是,开启重定向后,依然可以选择 继续开启 websocket 是需求。

Is it a possible requirement need @spacewander @tzssangglass 's help, since @spacewander has helped confirmed that when enable redirect plugin, we do not need enable_websocket field.

@spacewander
Copy link
Member

I see. When the user enables http_to_https, the redirect only happens with HTTP request. So they can still do websocket handshake with the HTTPS request.

@liuxiran
Copy link
Contributor

I see. When the user enables http_to_https, the redirect only happens with HTTP request. So they can still do websocket handshake with the HTTPS request.

thanks @spacewander , that means user can configure the enable_websocket and it can take action, right?

@spacewander
Copy link
Member

Yes

@liuxiran
Copy link
Contributor

其实就是想这个 UI 能发挥自身的作用,个别功能是缺失的

welcome to submit issues about missing features, that would be very helpful to make dashboard work better with APISIX.

Meanwhile, we are now working on making dashboard work smoothly with APISIX2.7, see here: https://github.com/apache/apisix-dashboard/milestone/15, and will soon arrange our milestone 2.8(work with APISIX 2.8) and 2.9 (work with APISIX 2.9), welcome to participate in, thanks @bingoku

@liuxiran liuxiran added this to the 2.7.2 milestone Aug 25, 2021
@liuxiran
Copy link
Contributor

Yes

got you, thanks, add this bug to 2.7.2 milestone.

@liuxiran
Copy link
Contributor

Hi @iamayushdas , would you like to try to fix this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
4 participants