Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upstream.checks.active.port should not set to 80 by default #2186

Closed
jagerzhang opened this issue Oct 27, 2021 · 0 comments · Fixed by #2278
Closed

upstream.checks.active.port should not set to 80 by default #2186

jagerzhang opened this issue Oct 27, 2021 · 0 comments · Fixed by #2278
Labels

Comments

@jagerzhang
Copy link

jagerzhang commented Oct 27, 2021

在Admin API 里面可以看到,upstream.checks.active.port 默认值是 ${upstream.node.port} ,即默认检查的是每个node定义的端口:
image

如果通过 Admin API 创建upstream的时候未定义upstream.checks.active.port(即本意是想使用默认的node 端口),但是在dashboard里面会默认为80:
image

如果有人通过dashboard去修改已有的upstream,一旦没注意把80改掉,就会导致检查端口变成80,所以建议在dashboard设置upstream.node.port的默认值为空,如果为空,那么就使用 ${upstream.node.port} 这个默认值。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants