Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can not open consumer with numbers as name #2196

Closed
hozaifaaoud opened this issue Nov 2, 2021 · 4 comments · Fixed by #2232
Closed

can not open consumer with numbers as name #2196

hozaifaaoud opened this issue Nov 2, 2021 · 4 comments · Fixed by #2232
Assignees
Labels
bug Something isn't working

Comments

@hozaifaaoud
Copy link

hozaifaaoud commented Nov 2, 2021

Issue description

The issue is that you can add a consumer through admin api and his name is 12345.
and if you go to the dashboard you will not be able to change any thing in this consumer configuration.
Here is a created user and I need to change something in its configuration
image

Expected behavior

//

How to Reproduce

//

Screenshots

No response

Environment

  • apisix version (cmd: apisix version): 2.5
  • OS (cmd: uname -a): linux ubuntu
  • OpenResty / Nginx version (cmd: nginx -V or openresty -V): openresty/1.19.9.1
  • etcd version, if have (cmd: run etcd --version): 3.4.13
  • apisix-dashboard version, if have: 2.6
  • Browser version, if have:

Additional context

//

@hozaifaaoud hozaifaaoud added the bug Something isn't working label Nov 2, 2021
@zaunist
Copy link
Contributor

zaunist commented Dec 1, 2021

Hi, @hozaifaaoud, I checked this situation and reproduce this issue. It's occurred because APISIX support consumer name start with number, but APISIX-Dashboard does't support. Does the APISIX-Dashboard need to support consumer that start with number ?

@juzhiyuan @nic-chen @starsz Any suggestions?

image

@nic-chen
Copy link
Member

nic-chen commented Dec 1, 2021

we should keep the same with APISIX.

@juzhiyuan
Copy link
Member

@zaunist Please see https://github.com/apache/apisix/blob/master/apisix/schema_def.lua#L693 , may need to keep the regex the same as apisix.

@juzhiyuan juzhiyuan removed the checking label Dec 1, 2021
@zaunist
Copy link
Contributor

zaunist commented Dec 1, 2021

@zaunist Please see https://github.com/apache/apisix/blob/master/apisix/schema_def.lua#L693 , may need to keep the regex the same as apisix.

Fine,I am glad to make contribution for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants