After create a consumer on dashboard, apisix throw a exception #856

cleverpig · 2020-11-23T10:31:38Z

Bug report

After create a consumer on dashboard with this config.
{"algorithm":"HS256","base64_secret":false,"exp":86400,"key":"123"}

then Apisix throws exception:
2020/11/23 18:20:25 [error] 3694#3694: *40311 [lua] config_etcd.lua:483: failed to fetch data from etcd: failed to check item data of [/apisix/consumers] err:additional properties forbidden, found id, etcd key: /apisix/consumers, context: ngx.timer

And if deleted this consumer, exception will disappear.

How to Reproduce

Go to 'main menu'
Click on 'consumer'
Add new consumer with jwt auth.
See error in apisix log output

System information

OS: Centos7
Browser: Chrome, Firefox
dashboard version: checkout from the master
apisix version: checkout from the master

Screensnap

nic-chen · 2020-11-23T11:36:23Z

hi，
what is your APISIX and dashboard version？
thanks.

starsz · 2020-11-23T14:00:55Z

Hi, I think it's because Apisix-dashboard had written consumer data with id field into etcd.

@cleverpig you can have a try on the v2.0 branch.

membphis · 2020-11-23T15:04:25Z

@idbeta pls confirm this issue, it seems to be a bug

juzhiyuan · 2020-11-23T15:11:40Z

Please use the latest master codes, it's 2.1 now.

cleverpig · 2020-11-24T00:53:57Z

Please use the latest master codes, it's 2.1 now.

I used the latest version.

dashboard version: checkout from the master
apisix version: checkout from the master

spacewander · 2020-11-24T01:01:04Z

I guess it is because consumer id is removed in the master branch. We need to update the stored etcd data.
apache/apisix#2679
Sorry, I got it wrong. It looks more like dashboard's bug.

spacewander · 2020-11-24T02:01:09Z

@cleverpig
~~Could you show your dashboard commit so that we can reproduce the issue? It look like the latest dashboard (1a38fa6) doesn't write the id to etcd.~~
OK, I can confirm that the latest dashboard (1a38fa6) does write the id to etcd. Please ignore me.

juzhiyuan · 2020-11-24T02:51:39Z

apache/apisix#2829

@spacewander Just to make sure, this PR will fix this issue?

spacewander · 2020-11-24T03:09:46Z

Yes

idbeta · 2020-11-24T04:02:46Z

@idbeta pls confirm this issue, it seems to be a bug

~~My 2.1 version environment also has this problem.~~

sorry, 2.1 version environment did not reproduce this problem.

membphis · 2020-11-25T04:13:55Z

apache/apisix@c8823d0

fixed in APISIX already. @cleverpig you can make a try with this commit or the latest version of APISIX.

cleverpig · 2020-11-27T08:47:31Z

apache/apisix@c8823d0

fixed in APISIX already. @cleverpig you can make a try with this commit or the latest version of APISIX.

@membphis
I checked out the master version of APISIX, the problem still stay on after I'd created a consumer from dashboard.

2020/11/27 16:40:20 [error] 3280#3280: *53 [lua] config_etcd.lua:483: failed to fetch data from etcd: failed to check item data of [/apisix/consumers] err:additional properties forbidden, found id,  etcd key: /apisix/consumers, context: ngx.timer
2020/11/27 16:40:20 [error] 3279#3279: *36 [lua] config_etcd.lua:483: failed to fetch data from etcd: failed to check item data of [/apisix/consumers] err:additional properties forbidden, found id,  etcd key: /apisix/consumers, context: ngx.timer
2020/11/27 16:40:20 [error] 3283#3283: *16 [lua] config_etcd.lua:483: failed to fetch data from etcd: failed to check item data of [/apisix/consumers] err:additional properties forbidden, found id,  etcd key: /apisix/consumers, context: ngx.timer

It's the output from git log:

commit f4161d39a495879edffbc75e2099f6e487bae81d
Author: willmafh <[email protected]>
Date:   Wed Nov 25 19:27:04 2020 +0800

    chore: minor change in bin/apisix (#2847)
....
commit c8823d0eedcdc6e329afc48d6f41e7c92637ae28
Author: 罗泽轩 <[email protected]>
Date:   Tue Nov 24 11:02:44 2020 +0800

    **fix(consumer): keep the id field for compatibility (#2829)**

membphis · 2020-11-27T08:55:18Z

@spacewander Do you have any suggestion?

cleverpig · 2020-11-27T08:59:23Z

If I use curl script to access JWT authed page following the guide (https://github.com/apache/apisix/blob/master/doc/plugins/jwt-auth.md),
Apisix will throw 500 exception.

curl http://127.0.0.1:9080/index.html -H 'Authorization: eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJrZXkiOiJ1c2VyLWtleSIsImV4cCI6MTYwNjU1MzYwMH0.GnuK08zLtaNyNW6NiqhkBlnxe7amZpSltU2dYDRRJM4' -i
HTTP/1.1 500 Internal Server Error
Date: Fri, 27 Nov 2020 08:54:08 GMT
Content-Type: text/html; charset=utf-8
Content-Length: 174
Connection: close
Server: APISIX/2.0

<html>
<head><title>500 Internal Server Error</title></head>
<body>
<center><h1>500 Internal Server Error</h1></center>
<hr><center>openresty</center>
</body>

This is backend output:

2020/11/27 16:54:08 [error] 3280#3280: *36299 lua entry thread aborted: runtime error: ...0-master-version//deps/share/lua/5.1/resty/radixtree.lua:380: invalid IP address: invalid ip address: 
stack traceback:
coroutine 0:
        [C]: in function 'error'
        ...0-master-version//deps/share/lua/5.1/resty/radixtree.lua:341: in function 'pre_insert_route'
        ...0-master-version//deps/share/lua/5.1/resty/radixtree.lua:380: in function 'new'
        .../git-storage/apisix/apisix/http/router/radixtree_uri.lua:77: in function 'create_radixtree_router'
        .../git-storage/apisix/apisix/http/router/radixtree_uri.lua:84: in function 'match'
        /app/install/git-storage/apisix/apisix/init.lua:382: in function 'fun_org'
        /app/install/git-storage/apisix/apisix/debug.lua:132: in function 'http_access_phase'
        access_by_lua(nginx.conf:163):2: in main chunk, client: 127.0.0.1, server: , request: "GET /index.html HTTP/1.1", host: "127.0.0.1:9080"

spacewander · 2020-11-27T09:03:56Z

apache/apisix@c8823d0
fixed in APISIX already. @cleverpig you can make a try with this commit or the latest version of APISIX.

@membphis
I checked out the master version of APISIX, the problem still stay on after I'd created a consumer from dashboard.

2020/11/27 16:40:20 [error] 3280#3280: *53 [lua] config_etcd.lua:483: failed to fetch data from etcd: failed to check item data of [/apisix/consumers] err:additional properties forbidden, found id,  etcd key: /apisix/consumers, context: ngx.timer
2020/11/27 16:40:20 [error] 3279#3279: *36 [lua] config_etcd.lua:483: failed to fetch data from etcd: failed to check item data of [/apisix/consumers] err:additional properties forbidden, found id,  etcd key: /apisix/consumers, context: ngx.timer
2020/11/27 16:40:20 [error] 3283#3283: *16 [lua] config_etcd.lua:483: failed to fetch data from etcd: failed to check item data of [/apisix/consumers] err:additional properties forbidden, found id,  etcd key: /apisix/consumers, context: ngx.timer

It's the output from git log:

commit f4161d39a495879edffbc75e2099f6e487bae81d
Author: willmafh <[email protected]>
Date:   Wed Nov 25 19:27:04 2020 +0800

    chore: minor change in bin/apisix (#2847)
....
commit c8823d0eedcdc6e329afc48d6f41e7c92637ae28
Author: 罗泽轩 <[email protected]>
Date:   Tue Nov 24 11:02:44 2020 +0800

    **fix(consumer): keep the id field for compatibility (#2829)**

Can't reproduce at my side with commit f4161d39a495879edffbc75e2099f6e487bae81d.

spacewander · 2020-11-27T10:10:36Z

If I use curl script to access JWT authed page following the guide (https://github.com/apache/apisix/blob/master/doc/plugins/jwt-auth.md),
Apisix will throw 500 exception.

curl http://127.0.0.1:9080/index.html -H 'Authorization: eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJrZXkiOiJ1c2VyLWtleSIsImV4cCI6MTYwNjU1MzYwMH0.GnuK08zLtaNyNW6NiqhkBlnxe7amZpSltU2dYDRRJM4' -i
HTTP/1.1 500 Internal Server Error
Date: Fri, 27 Nov 2020 08:54:08 GMT
Content-Type: text/html; charset=utf-8
Content-Length: 174
Connection: close
Server: APISIX/2.0

<html>
<head><title>500 Internal Server Error</title></head>
<body>
<center><h1>500 Internal Server Error</h1></center>
<hr><center>openresty</center>
</body>

This is backend output:

2020/11/27 16:54:08 [error] 3280#3280: *36299 lua entry thread aborted: runtime error: ...0-master-version//deps/share/lua/5.1/resty/radixtree.lua:380: invalid IP address: invalid ip address: 
stack traceback:
coroutine 0:
        [C]: in function 'error'
        ...0-master-version//deps/share/lua/5.1/resty/radixtree.lua:341: in function 'pre_insert_route'
        ...0-master-version//deps/share/lua/5.1/resty/radixtree.lua:380: in function 'new'
        .../git-storage/apisix/apisix/http/router/radixtree_uri.lua:77: in function 'create_radixtree_router'
        .../git-storage/apisix/apisix/http/router/radixtree_uri.lua:84: in function 'match'
        /app/install/git-storage/apisix/apisix/init.lua:382: in function 'fun_org'
        /app/install/git-storage/apisix/apisix/debug.lua:132: in function 'http_access_phase'
        access_by_lua(nginx.conf:163):2: in main chunk, client: 127.0.0.1, server: , request: "GET /index.html HTTP/1.1", host: "127.0.0.1:9080"

Please run etcdctl --endpoints=$your_server get /apisix/route --prefix to get your route configuration and paste them here.

nic-chen · 2020-11-27T11:15:42Z

It may be the default value from json schema problem

cleverpig · 2020-11-27T12:00:31Z

my route configuration :

/apisix/routes/
init_dir
/apisix/routes/328530522223411227
{"id":"328530522223411227","create_time":1605349050,"update_time":1606124128,"uris":["/index.html"],"name":"httpd-front","methods":["GET","HEAD","POST","PUT","DELETE","OPTIONS","PATCH"],"hosts":["192.168.56.101"],"vars":[],"plugins":{"limit-conn":{"burst":4,"conn":2,"default_conn_delay":2,"key":"remote_addr","rejected_code":503},"limit-req":{"burst":5,"key":"remote_addr","rate":2,"rejected_code":503}},"upstream_id":"328530185320136731"}
/apisix/routes/328543152380051483
{"id":"328543152380051483","create_time":1605356578,"update_time":1606120439,"uris":["/demo/*"],"name":"swPractice","methods":["GET","HEAD","POST","PUT","DELETE","OPTIONS","PATCH"],"hosts":["192.168.56.101"],"vars":[],"plugins":{"skywalking":{"endpoint":"http://192.168.56.101:12800","sample_ratio":1}},"upstream_id":"328543040492797979"}
/apisix/routes/329827033766952987
{"id":"329827033766952987","create_time":1606121831,"update_time":1606466025,"uris":["/jwt-auth.html"],"name":"httpd-jwt-test","methods":["GET","HEAD","POST","PUT","DELETE","OPTIONS","PATCH"],"hosts":["192.168.56.101"],"remote_addrs":[""],"vars":[],"plugins":{"jwt-auth":{}},"upstream_id":"328530185320136731"}

@spacewander

spacewander · 2020-11-27T12:56:38Z

It may be the default value from json schema problem

@nic-chen
Do you mean the "remote_addrs":[""] in @cleverpig's route?

nic-chen · 2020-11-27T14:13:29Z

@spacewander

field algorithm defines a default value (HS256) in json schema, but creating a consumer on dashboard will not set this default value.

it's for consumer not route.

nic-chen · 2020-11-28T09:34:34Z

@cleverpig

Please run etcdctl --endpoints=$your_server get /apisix/consumer --prefix to get your consumer configuration and paste them here. Thanks.

membphis · 2020-11-28T15:16:24Z

@cleverpig you can make a try with the latest master branch or 2.1 branch

https://github.com/apache/apisix/tree/v2.1

I think this issue should have been fixed in APISIX

nic-chen · 2020-11-30T04:05:08Z

Can't reproduce at my side, please make sure you are running the new code. Thanks. @cleverpig

nic-chen · 2020-11-30T07:16:40Z

close it according we have test case for it:
https://github.com/apache/apisix-dashboard/blob/master/api/test/e2e/route_with_auth_plugin_test.go#L38-L125

feel free to reopen this issue if need.

cleverpig · 2020-11-30T08:07:34Z

@cleverpig

Please run etcdctl --endpoints=$your_server get /apisix/consumer --prefix to get your consumer configuration and paste them here. Thanks.

ok, I ran "etcdctl --endpoints=IP:port get /apisix/consumer --prefix", and got these:

/apisix/consumers/
init_dir
/apisix/consumers/jack
{"update_time":1606723309,"username":"jack","create_time":1606723309,"plugins":{"jwt-auth":{"secret":"my-secret-key","algorithm":"HS256","exp":86400,"key":"user-key"}}}

@nic-chen

cleverpig · 2020-11-30T08:08:18Z

@cleverpig you can make a try with the latest master branch or 2.1 branch

https://github.com/apache/apisix/tree/v2.1

I think this issue should have been fixed in APISIX

Sorry,it still...I updated apisix and dashboard.

membphis · 2020-11-30T08:15:29Z

@idbeta please confirm if you can reproduce this error

nic-chen · 2020-11-30T08:37:13Z

@cleverpig

If you are convenient, please contact my QQ

thanks.

cleverpig · 2020-12-01T03:23:14Z

ok

cleverpig · 2020-12-01T14:15:44Z

haha, we found tow little bugs! Thanks @nic-chen

1.Route: remote address is required, it must input.

if not, this exception will be thrown:

2.Consumer: JWT secret is required, it must input.

if not, this exception will be thrown:

nic-chen · 2020-12-01T14:46:37Z

Thanks for feedback. @cleverpig

nic-chen · 2020-12-01T15:14:36Z

there are two bugs:

when user not fill in remote address , remote_addrs should be [], but not [""]
the field secret of plugin jwt-auth should be required.

@membphis @juzhiyuan @spacewander

membphis · 2020-12-01T15:25:26Z

when user not fill in remote address , remote_addrs should be [], but not [""]

When the user not filled, should no field remote_addrs. this should be a bug of the frontend. @juzhiyuan

BTW, I think [""] should be an invalid input, the JSON schema should return wrong. I make a test, confirm this.

the field secret of plugin jwt-auth should be required.

this depends on APISIX, we can fix this bug at 2.2. @nic-chen would you like to create a new issue to APISIX?

nic-chen · 2020-12-01T15:32:32Z

this depends on APISIX, we can fix this bug at 2.2. @nic-chen would you like to create a new issue to APISIX?

APISIX fixed this by addon code，not schema

membphis · 2020-12-01T15:42:53Z

APISIX fixed this by addon code，not schema

manager-api should keep the same way ^_^

nic-chen · 2020-12-02T00:12:09Z

APISIX fixed this by addon code，not schema

manager-api should keep the same way ^_^

OK

nic-chen · 2020-12-02T10:27:40Z

when user not fill in remote address , remote_addrs should be [], but not [""]
has been fixed by fix: omit remote_addrs when users don't input it #948 and fix: hack to fix the checking of remote_addrs #952

the field secret of plugin jwt-auth should be required.
we will continue the work by test: need to do custom check for plugins #941

close this issue now.

cleverpig added the bug Something isn't working label Nov 23, 2020

juzhiyuan added this to the 2.2 milestone Nov 24, 2020

membphis modified the milestones: 2.2, 2.1.1 Nov 24, 2020

membphis added the backend label Nov 24, 2020

membphis closed this as completed Nov 25, 2020

spacewander reopened this Nov 27, 2020

juzhiyuan added the checking label Nov 27, 2020

nic-chen self-assigned this Nov 30, 2020

nic-chen closed this as completed Nov 30, 2020

membphis reopened this Nov 30, 2020

nic-chen mentioned this issue Dec 2, 2020

test: need to do custom check for plugins #941

Closed

10 tasks

juzhiyuan mentioned this issue Dec 2, 2020

bug: when user not fill in remote address , remote_addrs should be [], but not [""] #940

Closed

nic-chen closed this as completed Dec 2, 2020

After create a consumer on dashboard, apisix throw a exception #856

After create a consumer on dashboard, apisix throw a exception #856

Comments

cleverpig commented Nov 23, 2020

Bug report

How to Reproduce

System information

Screensnap

nic-chen commented Nov 23, 2020

starsz commented Nov 23, 2020

membphis commented Nov 23, 2020

juzhiyuan commented Nov 23, 2020

cleverpig commented Nov 24, 2020

spacewander commented Nov 24, 2020 • edited Loading

spacewander commented Nov 24, 2020 • edited Loading

juzhiyuan commented Nov 24, 2020

spacewander commented Nov 24, 2020

idbeta commented Nov 24, 2020 • edited Loading

membphis commented Nov 25, 2020

cleverpig commented Nov 27, 2020

membphis commented Nov 27, 2020

cleverpig commented Nov 27, 2020

spacewander commented Nov 27, 2020

spacewander commented Nov 27, 2020

nic-chen commented Nov 27, 2020

cleverpig commented Nov 27, 2020

spacewander commented Nov 27, 2020

nic-chen commented Nov 27, 2020

nic-chen commented Nov 28, 2020

membphis commented Nov 28, 2020 • edited Loading

nic-chen commented Nov 30, 2020

nic-chen commented Nov 30, 2020

cleverpig commented Nov 30, 2020

cleverpig commented Nov 30, 2020

membphis commented Nov 30, 2020

nic-chen commented Nov 30, 2020 • edited Loading

cleverpig commented Dec 1, 2020

cleverpig commented Dec 1, 2020

nic-chen commented Dec 1, 2020

nic-chen commented Dec 1, 2020

membphis commented Dec 1, 2020

nic-chen commented Dec 1, 2020

membphis commented Dec 1, 2020

nic-chen commented Dec 2, 2020

nic-chen commented Dec 2, 2020

spacewander commented Nov 24, 2020 •

edited

Loading

spacewander commented Nov 24, 2020 •

edited

Loading

idbeta commented Nov 24, 2020 •

edited

Loading

membphis commented Nov 28, 2020 •

edited

Loading

nic-chen commented Nov 30, 2020 •

edited

Loading