Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The length kernel should work with BinaryArrays #1464

Closed
HaoYang670 opened this issue Mar 18, 2022 · 3 comments · Fixed by #1465
Closed

The length kernel should work with BinaryArrays #1464

HaoYang670 opened this issue Mar 18, 2022 · 3 comments · Fixed by #1465
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@HaoYang670
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
The length kernel only supports StringArrays so far. I think it is reasonable to let it support BinaryArrays.

Describe the solution you'd like
let the function length and bit_length work with binary arrays
@HaoYang670 HaoYang670 added the enhancement Any new improvement worthy of a entry in the changelog label Mar 18, 2022
@HaoYang670 HaoYang670 changed the title length kernel should work with BinaryArrays The length kernel should work with BinaryArrays Mar 18, 2022
@HaoYang670
Copy link
Contributor Author

@alamb I have this idea because BinaryArray and StringArray are very similar. But I'm not sure whether we need this feature.

@alamb
Copy link
Contributor

alamb commented Mar 20, 2022

I think supporting length for BinaryArray makes sense and would be good to add for completeness

@HaoYang670
Copy link
Contributor Author

I think supporting length for BinaryArray makes sense and would be good to add for completeness

Great! I will file a PR today!

This was referenced Mar 20, 2022
Merged
Closed
@alamb alamb added the arrow Changes to the arrow crate label Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support the length kernel on Binary Array HaoYang670/arrow-rs
2 participants
@alamb @HaoYang670