Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant error checking in ListArray, BooleanArray, BinaryArray and PrimitiveArray #1545

Closed
Tracked by #1546
alamb opened this issue Apr 12, 2022 · 1 comment
Closed
Tracked by #1546
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@alamb
Copy link
Contributor

alamb commented Apr 12, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
#1546 revealed that several Array types have error checking that is now redundant with ArrayData::validate_full().

Describe the solution you'd like
Remove the redudant error checks and stop ignoring them during force validate run:

    #[cfg(not(feature = "force_validate"))]

The tests should continue to pass when run with

cargo test --features=force_validate -p arrow

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@alamb alamb added the enhancement Any new improvement worthy of a entry in the changelog label Apr 12, 2022
@alamb alamb changed the title Redundant error checking Redundant error checking in ListArray, BooleanArray, BinaryArray and PrimitiveArray Apr 12, 2022
@alamb alamb added the arrow Changes to the arrow crate label Apr 12, 2022
@tustvold tustvold closed this as completed Nov 1, 2022
@tustvold
Copy link
Contributor

tustvold commented Nov 1, 2022

I believe this is no longer the case, feel free to reopen if I am mistaken

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

No branches or pull requests

2 participants