Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send + Sync impl for Allocation may not be sound unless Allocation is Send + Sync as well #1944

Closed
jhorstmann opened this issue Jun 24, 2022 · 0 comments · Fixed by #1945
Closed

Send + Sync impl for Allocation may not be sound unless Allocation is Send + Sync as well #1944

jhorstmann opened this issue Jun 24, 2022 · 0 comments · Fixed by #1945
Labels
arrow Changes to the arrow crate bug

Comments

@jhorstmann
Copy link
Contributor

Describe the bug

As noted by @jorgecarleitao in jorgecarleitao/arrow2#1099 (comment) the unsafe impl of Send + Sync for Buffer might not be sound if the custom Allocation is not also Send + Sync.

Expected behavior

Allocation should require RefUnwindSafe + Send + Sync. Bytes probably still needs an unsafe Send + Sync impl, but Buffer should then be automatically Send + Sync.
@jhorstmann jhorstmann added the bug label Jun 24, 2022
@jhorstmann jhorstmann mentioned this issue Jun 24, 2022
Merged
@alamb alamb changed the title Send + Sync impl for Allocation might be unsound Send + Sync impl for Allocation may not be sound unless Allocation is Send + Sync as well Jul 7, 2022
@alamb alamb added the arrow Changes to the arrow crate label Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow Changes to the arrow crate bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Require Send+Sync bounds for Allocation trait jhorstmann/arrow-rs
2 participants
@alamb @jhorstmann