Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo docs nightly fails. #2385

Closed
HaoYang670 opened this issue Aug 9, 2022 · 2 comments
Closed

cargo docs nightly fails. #2385

HaoYang670 opened this issue Aug 9, 2022 · 2 comments
Labels
arrow Changes to the arrow crate development-process Related to development process of arrow-rs

Comments

@HaoYang670
Copy link
Contributor

Describe the bug

To Reproduce

cargo doc --document-private-items --no-deps --workspace --all-features

using the nightly tool chain.

Get error

warning: unnecessary `unsafe` block
   --> arrow/src/compute/kernels/arithmetic.rs:369:17
    |
369 |                 unsafe { result.typed_data_mut().chunks_exact_mut(64) };
    |                 ^^^^^^ unnecessary `unsafe` block
    |
    = note: `#[warn(unused_unsafe)]` on by default

warning: unnecessary `unsafe` block
   --> arrow/src/compute/kernels/arithmetic.rs:417:17
    |
417 |                 unsafe { result.typed_data_mut().chunks_exact_mut(lanes) };
    |                 ^^^^^^ unnecessary `unsafe` block

warning: unnecessary `unsafe` block
    --> arrow/src/compute/kernels/comparison.rs:1700:25
     |
1700 |     let result_chunks = unsafe { result.typed_data_mut() };
     |                         ^^^^^^ unnecessary `unsafe` block
...

Expected behavior

Additional context

@HaoYang670
Copy link
Contributor Author

I am not sure whether this is related to the new released rust 1.65.0 nightly

@HaoYang670
Copy link
Contributor Author

Close this issue as I don't find the error is reproduced in other PR's CI.

@alamb alamb added the arrow Changes to the arrow crate label Aug 10, 2022
@alamb alamb added development-process Related to development process of arrow-rs and removed bug labels Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate development-process Related to development process of arrow-rs
Projects
None yet
Development

No branches or pull requests

2 participants