Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support empty projection in RecordBatch::project #2690

Closed
Dandandan opened this issue Sep 8, 2022 · 1 comment · Fixed by #2691
Closed

Support empty projection in RecordBatch::project #2690

Dandandan opened this issue Sep 8, 2022 · 1 comment · Fixed by #2691
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@Dandandan
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
When trying to work on removing the workaround for empty projections in DataFusion, I saw RecordBatch::project currently doesn't support empty projections. Doing so would make it easier to remove this workaround in the future.

Describe the solution you'd like

We can add support for this.

Describe alternatives you've considered

Additional context
@Dandandan Dandandan added the enhancement Any new improvement worthy of a entry in the changelog label Sep 8, 2022
@Dandandan Dandandan changed the title Support empty projection in RecordBatch::project Support empty projection in `RecordBatch::project Sep 8, 2022
@Dandandan Dandandan changed the title Support empty projection in `RecordBatch::project Support empty projection in RecordBatch::project Sep 8, 2022
@Dandandan Dandandan mentioned this issue Sep 8, 2022
Merged
@alamb
Copy link
Contributor

alamb commented Sep 16, 2022

label_issue.py automatically added labels {'arrow'} from #2691

@alamb alamb added the arrow Changes to the arrow crate label Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for empty projection in RecordBatch::project Dandandan/arrow-rs
2 participants
@Dandandan @alamb