Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent Nan Handling Between Scalar and Non-Scalar Comparison Kernels #3074

Closed
tustvold opened this issue Nov 10, 2022 · 2 comments · Fixed by #3075
Closed

Inconsistent Nan Handling Between Scalar and Non-Scalar Comparison Kernels #3074

tustvold opened this issue Nov 10, 2022 · 2 comments · Fixed by #3075
Labels
arrow Changes to the arrow crate bug

Comments

@tustvold
Copy link
Contributor

Describe the bug

The scalar kernels use ArrowNativeTypeOp and therefore total_cmp to order values, the non-scalar kernels do not.

To Reproduce

Expected behavior

Additional context
@tustvold tustvold added the bug label Nov 10, 2022
@viirya
Copy link
Member

viirya commented Nov 10, 2022

Oh, I may miss this piece. I will work on filling this gap after verifying it.

@viirya viirya mentioned this issue Nov 10, 2022
Merged
@alamb alamb added the arrow Changes to the arrow crate label Nov 11, 2022
@alamb
Copy link
Contributor

alamb commented Nov 11, 2022

label_issue.py automatically added labels {'arrow'} from #3075

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow Changes to the arrow crate bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use ArrowNativeTypeOp on non-scalar comparison kernels viirya/arrow-rs
3 participants
@viirya @alamb @tustvold