Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decimal arithmetic computation fails to run because decimal type equality #3344

Closed
viirya opened this issue Dec 15, 2022 · 1 comment · Fixed by #3345
Closed

Decimal arithmetic computation fails to run because decimal type equality #3344

viirya opened this issue Dec 15, 2022 · 1 comment · Fixed by #3345
Labels
arrow Changes to the arrow crate bug

Comments

@viirya
Copy link
Member

viirya commented Dec 15, 2022

Describe the bug

The functions like unary_dyn fails to compute if it finds inequality between array type and operation operand type:

For decimal types, just precision/scale can also fail the type equality. Because decimal types have default precision and scale, such check makes no sense for decimal types:

NotYetImplemented("Cannot perform unary operation of type Decimal128(38, 10) on array of type Decim
al128(38, 2)")'

This makes scalar arithmetic kernels cannot work on decimal types mostly.

To Reproduce

Expected behavior

Additional context

@alamb
Copy link
Contributor

alamb commented Dec 29, 2022

label_issue.py automatically added labels {'arrow'} from #3345

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants