We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is your feature request related to a problem or challenge? Please describe what you are trying to do.
I suspect this will be a controversial issue, but there a couple of reasons for proposing this
FromIterator
Extend
Describe the solution you'd like
Panic on key overflow instead of returning an error
Describe alternatives you've considered
We could implement Extend and panic on key overflow there, much like we do for FromIterator, but I feel we should be consistent about this.
We could also implement our own TryExtend trait or something similar.
TryExtend
Additional context
#2725 tracks a more holistic rework of how we handle errors
The text was updated successfully, but these errors were encountered:
My personal opinion is that the client code should be able to avoid panic's if the user desires, but that doesn't mean the API needs to be fallible.
For example, as long as it is possible to pre-compute / estimate when a panic would occur (either explained via docs or some sort of calculation with https://docs.rs/arrow/31.0.0/arrow/array/struct.ArrayData.html#method.get_slice_memory_size or something) then 👍
Sorry, something went wrong.
RunEndEncodedArray
label_issue.py automatically added labels {'arrow'} from #3563
label_issue.py
label_issue.py automatically added labels {'parquet'} from #3553
Successfully merging a pull request may close this issue.
Is your feature request related to a problem or challenge? Please describe what you are trying to do.
I suspect this will be a controversial issue, but there a couple of reasons for proposing this
FromIterator
andExtend
assume infallibilityDescribe the solution you'd like
Panic on key overflow instead of returning an error
Describe alternatives you've considered
We could implement
Extend
and panic on key overflow there, much like we do for FromIterator, but I feel we should be consistent about this.We could also implement our own
TryExtend
trait or something similar.Additional context
#2725 tracks a more holistic rework of how we handle errors
The text was updated successfully, but these errors were encountered: