-
Notifications
You must be signed in to change notification settings - Fork 853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent UnionArray with Repeated Type IDs #3982
Comments
Could I pick this ticket up? |
Sure, as the maximum id is 127, you can probably just use an |
Should we guarantee that |
The arrow format specifies the following - https://arrow.apache.org/docs/format/Columnar.html#union-layout
So they should be signed integers, but never negative 😅. Most likely this was originally a workaround for Java |
|
|
Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Currently
DataType::Union
has no protection against the same type ID appearing multiple times in itsDataType
.Describe the solution you'd like
We should probably validate that the
type_ids
are unique, and prevent constructing an invalidDataType
Describe alternatives you've considered
We could not do this, much like currently permit invalid
DataType::Decimal
#2362Additional context
The text was updated successfully, but these errors were encountered: