Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formalize the name of the nested Field in a list #6784

Closed
gruuya opened this issue Nov 25, 2024 · 0 comments · Fixed by #6785
Closed

Formalize the name of the nested Field in a list #6784

gruuya opened this issue Nov 25, 2024 · 0 comments · Fixed by #6785
Labels
enhancement Any new improvement worthy of a entry in the changelog

Comments

@gruuya
Copy link
Contributor

gruuya commented Nov 25, 2024

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
As discussed in apache/datafusion#13468 (comment), currently it is a convention to have list field member fields (i.e. the inner field) names be item. However this is not formalized in any way, and consequently there's a large number of item literals thrown around the codebase.

Describe the solution you'd like
Add a Field::LIST_FIELD_DEFAULT_NAME constant set to item, and use it in Field::new_list_field.

Also replace any calls to Field::new with explicit item name to use Field::new_list_field instead.

Describe alternatives you've considered
Could also make a free-standing as opposed to an associated constant (or not extract into a constant at all).

Additional context
Spin-off out of apache/datafusion#13468

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant