Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance arrow-json reader/writer builder pattern to enforce constraints #7025

Open
Jefffrey opened this issue Jan 26, 2025 · 0 comments
Open

Comments

@Jefffrey
Copy link
Contributor

#6643 introduced new options which affect existing options in the builders.

Examples:

let reader = ReaderBuilder::new(schema)
    .with_struct_mode(StructMode::ListOnly)
    .with_strict_mode(false) // This has no effect
    .build();

let writer = WriterBuilder::new()
    .with_struct_mode(StructMode::ListOnly)
    .with_explicit_nulls(false) // This has no effect
    .build()

See if we can utilize Rust's type system to enforce these constraints (e.g. type-state builder pattern). Would likely require a breaking API change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant