Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing safety comments for calling ArrowDataBuilder::build_unchecked in Parquet #7044

Open
jp0317 opened this issue Jan 29, 2025 · 1 comment
Labels
enhancement Any new improvement worthy of a entry in the changelog

Comments

@jp0317
Copy link
Contributor

jp0317 commented Jan 29, 2025

Describe the bug
There are some places in the Parquet codes (mostly in arrow interfaces, e.g., here and here) calling the ArrowDataBuilder::build_unchecked without clear safety comments. In particular, it is not straightforwardly clear that whether the inputs do form valid Arrow Array.

To Reproduce
n/a

Expected behavior
Calling unsafe functions should have clear safety comments

Additional context

@jp0317 jp0317 added the bug label Jan 29, 2025
@tustvold tustvold added enhancement Any new improvement worthy of a entry in the changelog and removed bug labels Jan 29, 2025
@alamb
Copy link
Contributor

alamb commented Jan 30, 2025

Thank you @jp0317

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

No branches or pull requests

3 participants