Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Missing kernel for replace_with_mask with halffloat #37027

Open
spenczar opened this issue Aug 4, 2023 · 2 comments
Open

[C++] Missing kernel for replace_with_mask with halffloat #37027

spenczar opened this issue Aug 4, 2023 · 2 comments

Comments

@spenczar
Copy link
Contributor

spenczar commented Aug 4, 2023

Describe the enhancement requested

There might well be an umbrella issue for this. But with pyarrow, pa.compute.replace_with_mask is currently lacking a kernel for filling in halffloat values. I get a pyarrow.lib.ArrowNotImplementedError: Function 'replace_with_mask' has no kernel matching input types (halffloat, bool, halffloat) error when I try.

Component(s)

Python

@js8544
Copy link
Collaborator

js8544 commented Aug 8, 2023

The support for half float type is extremely limited at the moment. I don't think there is any function that supports it? There is a recent discussion though: #22806.

@pitrou
Copy link
Member

pitrou commented Aug 22, 2023

For many purposes such as copying values, float16 type can be treated as an opaque type and handled internally just like uint16. So this feature request and other similar ones could probably be addressed easily.

@pitrou pitrou changed the title Missing kernel for replace_with_mask with halffloat [C++] Missing kernel for replace_with_mask with halffloat Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants