Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R] R package arm64 build fails due to missing brotlienc-static #37685

Closed
assignUser opened this issue Sep 13, 2023 · 4 comments
Closed

[R] R package arm64 build fails due to missing brotlienc-static #37685

assignUser opened this issue Sep 13, 2023 · 4 comments
Labels
Component: R Priority: Blocker Marks a blocker for the release Type: bug

Comments

@assignUser
Copy link
Member

Describe the bug, including details regarding any error messages, version, and platform.

See r-binary-packages nightlies: https://github.com/ursacomputing/crossbow/actions/runs/6156959279/job/16707483446#step:13:7536

Component(s)

R

@kou
Copy link
Member

kou commented Sep 14, 2023

Homebrew/homebrew-core#140964 and google/brotli#655 may be related.

It seems that Brotli 1.1.0 doesn't support building both of shared libraries and static libraries. And Homebrew's brotli formula does nothing. So brotli formula 1.1.0 doesn't include static libraries of Brotli. And we hard-code -lbrotlienc-static -lbrotlidec-static -lbrotlicommon-static:

PKG_LIBS="-lparquet -larrow_dataset -larrow_acero -larrow -larrow_bundled_dependencies -lthrift -lbrotlienc-static -lbrotlidec-static -lbrotlicommon-static -llz4 -lsnappy -lzstd $AWS_LIBS -lssl -lcrypto"

@thisisnic thisisnic added the Priority: Blocker Marks a blocker for the release label Sep 14, 2023
@assignUser
Copy link
Member Author

Ah thanks for the investigation! As this builds the R package we can not link shared... but we are also getting rid of the autobrew path so I am not sure how much sense it makes to spend time on this?

@assignUser
Copy link
Member Author

(we should be able to use bundled brotli no?)

@assignUser
Copy link
Member Author

#37923 does not have this problem so I am closing this as not planned.

@assignUser assignUser closed this as not planned Won't fix, can't repro, duplicate, stale Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: R Priority: Blocker Marks a blocker for the release Type: bug
Projects
None yet
Development

No branches or pull requests

3 participants