AVRO-3649: Fix for union type to match default values for any innertype #2503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opwvhk
reviewed
Sep 19, 2023
| @@ -421,6 +426,53 @@ void qualifiedName() { | |||
| assertEquals("Int", nameInt.getQualified("space")); | |||
| } | |||
|
|
|||
| @Test | |||
| void validValue() { | |||
There was a problem hiding this comment.
Do we want the name to explicitly mention we're testing default values here?
(a matter of style/opinion only)
RanbirK
pushed a commit
to RanbirK/avro
that referenced
this pull request
May 13, 2024
…pe (apache#2503) * avro-3649: Union type to match default values for any innertype
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Change the logic on Union type to validate a value (default value in particular) for AVRO-3649. Instead of check value with first union inner type, try with inner type until find a match.
Verifying this change
Some test were updated.
Documentation