AVRO-4068: Java Code Cleanup #3192
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
belugabehr
commented
Sep 30, 2024
| @@ -192,7 +192,7 @@ public BigDecimal fromBytes(final ByteBuffer value, final Schema schema, final L | |||
| BigInteger bg = null; | |||
| ByteBuffer buffer = decoder.readBytes(null); | |||
| byte[] array = buffer.array(); | |||
| if (array != null && array.length > 0) { | |||
| if (array.length > 0) { | |||
There was a problem hiding this comment.
This cannot be null
belugabehr
commented
Sep 30, 2024
| @@ -206,7 +206,7 @@ public int size() { | |||
| this.reserved = reserved; | |||
| for (Entry<String, ?> a : propMap.entrySet()) { | |||
| Object v = a.getValue(); | |||
| JsonNode json = null; | |||
| JsonNode json; | |||
There was a problem hiding this comment.
This always gets overwritten
belugabehr
commented
Sep 30, 2024
| @@ -71,11 +70,9 @@ public class Protocol extends JsonProperties { | |||
| public static final long VERSION = 1; | |||
|
|
|||
| // Support properties for both Protocol and Message objects | |||
| private static final Set<String> MESSAGE_RESERVED = Collections | |||
| .unmodifiableSet(new HashSet<>(Arrays.asList("doc", "response", "request", "errors", "one-way"))); | |||
| private static final Set<String> MESSAGE_RESERVED = Set.of("doc", "response", "request", "errors", "one-way"); | |||
There was a problem hiding this comment.
Use new Set.of(xxx)
belugabehr
commented
Sep 30, 2024
| @@ -27,7 +27,6 @@ private DataFileConstants() { | |||
|
|
|||
| public static final byte VERSION = 1; | |||
| public static final byte[] MAGIC = new byte[] { (byte) 'O', (byte) 'b', (byte) 'j', VERSION }; | |||
| public static final long FOOTER_BLOCK = -1; | |||
belugabehr
commented
Sep 30, 2024
Comment on lines
-369
to
-384
| byte[] getData() { | ||
| return data; | ||
| } | ||
|
|
||
| long getNumEntries() { | ||
| return numEntries; | ||
| } | ||
|
|
||
| int getBlockSize() { | ||
| return blockSize; | ||
| } | ||
|
|
||
| boolean isFlushOnWrite() { | ||
| return flushOnWrite; | ||
| } | ||
|
|
belugabehr
commented
Sep 30, 2024
| @@ -26,15 +26,14 @@ | |||
| import org.apache.avro.util.NonCopyingByteArrayOutputStream; | |||
| import org.apache.commons.compress.compressors.xz.XZCompressorInputStream; | |||
| import org.apache.commons.compress.compressors.xz.XZCompressorOutputStream; | |||
| import org.apache.commons.compress.utils.IOUtils; | |||
belugabehr
commented
Sep 30, 2024
| @@ -72,7 +71,7 @@ public ByteBuffer decompress(ByteBuffer data) throws IOException { | |||
| InputStream bytesIn = new ByteArrayInputStream(data.array(), computeOffset(data), data.remaining()); | |||
|
|
|||
| try (InputStream ios = new XZCompressorInputStream(bytesIn)) { | |||
| IOUtils.copy(ios, baos); | |||
| ios.transferTo(baos); | |||
There was a problem hiding this comment.
new JDK9+ syntax
belugabehr
commented
Sep 30, 2024
Comment on lines
-45
to
-49
| @Override | ||
| public boolean markSupported() { | ||
| return false; | ||
| } | ||
|
|
There was a problem hiding this comment.
Same implementation as parent/super class
belugabehr
force-pushed
the
belugabehr/AVRO-4068
branch
from
83f23c8 to
39e70ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.