Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize python type hints for apache_beam. #32872

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

robertwb
Copy link
Contributor

This was done with com2ann plus some manaual edits.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@robertwb
Copy link
Contributor Author

R: @tvalentyn

Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

This was done with com2ann plus some manaual edits.
@tvalentyn
Copy link
Contributor

cc: @jrmccluskey

@tvalentyn tvalentyn closed this Nov 12, 2024
@tvalentyn tvalentyn reopened this Nov 12, 2024
@tvalentyn
Copy link
Contributor

Reopening to rerun the test in case master changed

@robertwb
Copy link
Contributor Author

Thanks. I thought all tests were passing before, I'll look into the failure here. (I do see a lot of

>   self._maybe_sample_exception(exc_info, windowed_value)
E   TypeError: Argument 'exn' has incorrect type (expected BaseException, got tuple)

which is a bit odd.)

@jrmccluskey
Copy link
Contributor

Thanks. I thought all tests were passing before, I'll look into the failure here. (I do see a lot of

>   self._maybe_sample_exception(exc_info, windowed_value)
E   TypeError: Argument 'exn' has incorrect type (expected BaseException, got tuple)

which is a bit odd.)

those should be fixed now, @damccorm addressed those this week

@damccorm
Copy link
Contributor

Yeah, you may need to push a dummy commit to rerun though

@robertwb robertwb closed this Nov 14, 2024
@robertwb robertwb reopened this Nov 14, 2024
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.99%. Comparing base (f4d07c4) to head (2d69dde).
Report is 41 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #32872      +/-   ##
============================================
+ Coverage     58.87%   58.99%   +0.12%     
  Complexity     3112     3112              
============================================
  Files          1130     1133       +3     
  Lines        174455   174905     +450     
  Branches       3343     3343              
============================================
+ Hits         102716   103193     +477     
+ Misses        68392    68365      -27     
  Partials       3347     3347              
Flag Coverage Δ
python 81.58% <100.00%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@robertwb robertwb merged commit 75fd964 into apache:master Nov 19, 2024
94 of 95 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants