-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize python type hints for apache_beam. #32872
Conversation
R: @tvalentyn |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
e8b4227
to
edf7abf
Compare
This was done with com2ann plus some manaual edits.
edf7abf
to
10689f2
Compare
cc: @jrmccluskey |
Reopening to rerun the test in case master changed |
Thanks. I thought all tests were passing before, I'll look into the failure here. (I do see a lot of
which is a bit odd.) |
those should be fixed now, @damccorm addressed those this week |
Yeah, you may need to push a dummy commit to rerun though |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #32872 +/- ##
============================================
+ Coverage 58.87% 58.99% +0.12%
Complexity 3112 3112
============================================
Files 1130 1133 +3
Lines 174455 174905 +450
Branches 3343 3343
============================================
+ Hits 102716 103193 +477
+ Misses 68392 68365 -27
Partials 3347 3347
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
This was done with com2ann plus some manaual edits.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.