Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid rdma::GlobalRelease before event dispatcher is stopped #2220

Merged
merged 1 commit into from
Apr 23, 2023

Conversation

Tuvie
Copy link
Contributor

@Tuvie Tuvie commented Apr 22, 2023

What problem does this PR solve?

Issue Number: #2213

Problem Summary: rdma::GlobalRelease runs before event dispatcher is stopped. It may incur coredump during program exit.

What is changed and the side effects?

Changed: the order of atexit on rdma::GlobalRelease

Side effects:

  • Performance effects(性能影响):

  • Breaking backward compatibility(向后兼容性):


Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

@Tuvie Tuvie mentioned this pull request Apr 22, 2023
@wwbmmm wwbmmm merged commit 80a4906 into apache:master Apr 23, 2023
yanglimingcn pushed a commit to yanglimingcn/brpc that referenced this pull request Jun 25, 2023
yanglimingcn pushed a commit to yanglimingcn/brpc that referenced this pull request Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants