-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix invalid headers of multiple cookie and set-cookie #2577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@wwbmmm 有空看看这个PR |
这个改动可能会影响性能?有没有和原来的实现做对比 |
wwbmmm
reviewed
Apr 1, 2024
unordered_multimap性能肯定比FlatMap性能差。另外,上面通过遍历来获取key对应的所有value的方法也是比较低效的。或许,实现一个multi版本的FlatMap更合适。 |
chenBright
force-pushed
the
cookie
branch
4 times, most recently
from
April 14, 2024 05:54
7abda2b
to
777e67c
Compare
在FlatMap的基础上支持Multi,Multi FlatMap性能跟FlatMap相当,比std::unordered_(multi)map好一些。以下是在本地运行FlatMapTest.perf得到的性能比较:
|
wwbmmm
reviewed
Apr 22, 2024
LGTM |
解决与主干的冲突 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: resolve #2575
Problem Summary:
目前bRPC处理cookie和set-cookie这两个header的逻辑有问题:
,
分隔,应该要用;
;What is changed and the side effects?
Changed:
;
分隔;2.1 GetHeader、SetHeader只对第一个set-cookie生效。当只有一个set-cookie的时候,这两个api的表现不变。
2.2 AppendHeader会直接创建新的set-cookie。
2.3 HeaderBegin和HeaderEnd这两个api表现不变,还是可以遍历到所有header。
Side effects:
Performance effects(性能影响):
Breaking backward compatibility(向后兼容性):
Check List: