Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate code to use ScalarUDF::invoke_batch and ScalarUDFImpl::invoke_batch #13238

Closed
findepi opened this issue Nov 3, 2024 · 2 comments · Fixed by #13345
Closed

Migrate code to use ScalarUDF::invoke_batch and ScalarUDFImpl::invoke_batch #13238

findepi opened this issue Nov 3, 2024 · 2 comments · Fixed by #13345
Assignees
Labels
good first issue Good for newcomers

Comments

@findepi
Copy link
Member

findepi commented Nov 3, 2024

Migrate code from ScalarUDF::invoke and invoke_no_arg to use ScalarUDF::invoke_batch
And from ScalarUDFImpl::invoke and invoke_no_arg ScalarUDFImpl::invoke_batch.

The places in the code to be changed can be found by searching for #[allow(deprecated)] // TODO migrate UDF invoke to invoke_batch

@irenjj
Copy link
Contributor

irenjj commented Nov 4, 2024

take

@findepi
Copy link
Member Author

findepi commented Nov 4, 2024

@irenjj thanks!
it would be better to wait for #13174 to be merged first.
#13246 migrates invoke_no_arg, but definitely more work is for the regular invoke, your help here would be awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants