Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo clippy fails on the master branch #1880

Closed
HaoYang670 opened this issue Feb 25, 2022 · 2 comments · Fixed by #1885
Closed

cargo clippy fails on the master branch #1880

HaoYang670 opened this issue Feb 25, 2022 · 2 comments · Fixed by #1885
Labels
bug Something isn't working

Comments

@HaoYang670
Copy link
Contributor

HaoYang670 commented Feb 25, 2022 •
edited
Loading

Describe the bug
After update rustup to the latest version rustc 1.59.0, running cargo clippy on master branch fails.

To Reproduce

  1. update rustup to the latest version rustc 1.59.0
  2. run cargo clippy --all-targets --workspace -- -D warnings on master branch
  3. build failed

Expected behavior
No error.

Additional context
Found the bug from #1878
Same error in arrow-rs: apache/arrow-rs#1362
@HaoYang670 HaoYang670 added the bug Something isn't working label Feb 25, 2022
@HaoYang670
Copy link
Contributor Author

@houqp

@houqp
Copy link
Member

houqp commented Feb 25, 2022

This happens on almost every rust release :D @HaoYang670 please feel free to send a PR to fix those warnings.

@HaoYang670 HaoYang670 mentioned this issue Feb 25, 2022
Merged
@Ted-Jiang Ted-Jiang mentioned this issue Feb 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix clippy lints HaoYang670/arrow-datafusion
2 participants
@houqp @HaoYang670