Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ScalarValue::Union variant #8500

Closed
thinkharderdev opened this issue Dec 11, 2023 · 2 comments · Fixed by #9683
Closed

Add ScalarValue::Union variant #8500

thinkharderdev opened this issue Dec 11, 2023 · 2 comments · Fixed by #9683
Labels
enhancement New feature or request

Comments

@thinkharderdev
Copy link
Contributor

Is your feature request related to a problem or challenge?

Currently there is no scalar representation of a Union type which can cause issue in cases where we rely on ScalarValue (see #8499 for the issue that is prompting this request)

Describe the solution you'd like

Define a ScalarValue::Union variant. I think this should be as simple as:

enum ScalarValue {
   ...
   Union(i8,Box<ScalarValue>)
}

That is, just wraps another ScalarValue along with the type_id

Describe alternatives you've considered

Not do anything

Additional context

No response

@thinkharderdev thinkharderdev added the enhancement New feature or request label Dec 11, 2023
@thinkharderdev
Copy link
Contributor Author

@Dandandan

@Tangruilin
Copy link
Contributor

@thinkharderdev This looks interesting,are you working on it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants