Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

to_char(.., null) should be NULL, not .. #9217

Closed
alamb opened this issue Feb 13, 2024 · 6 comments · Fixed by #9689
Closed

to_char(.., null) should be NULL, not .. #9217

alamb opened this issue Feb 13, 2024 · 6 comments · Fixed by #9689
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@alamb
Copy link
Contributor

alamb commented Feb 13, 2024

The newly added to_char's null handling is not quite correct -- specifically when the format string is null, the output should be null, but now it returns the first argument

Goal is to make to_char do what postgres does:

          Postgres seems to think this should be null
postgres=# select to_char(interval '1 day', null);
 to_char
---------

(1 row)

Originally posted by @alamb in #9181 (comment)

@alamb
Copy link
Contributor Author

alamb commented Feb 13, 2024

There are existing tests in timestamp.slt, this should simply be a matter of updating the code (see #9181) -- I think this would be a good first issue

@alamb alamb added bug Something isn't working good first issue Good for newcomers labels Feb 13, 2024
@manoj-inukolunu
Copy link
Contributor

take

@tinfoil-knight
Copy link
Contributor

@manoj-inukolunu Are you still working on this? (If not, could you please un-assign yourself. I'd like to attempt the fix for this issue)

@manoj-inukolunu
Copy link
Contributor

Hey so sorry not working on it right now , swamped with work .

@manoj-inukolunu
Copy link
Contributor

unassign

@manoj-inukolunu manoj-inukolunu removed their assignment Mar 13, 2024
@tinfoil-knight
Copy link
Contributor

take

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants