-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature](write)add metrics for flink load data #287
Conversation
String.format( | ||
METRIC_NAME_FORMAT, | ||
tableIdentifier, | ||
subTaskId, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to add subTaskId? It seems to be there by default?
.ifPresent(totalFlushNumberTotalRows::inc); | ||
Optional.ofNullable(responseContent.getNumberFilteredRows()) | ||
.ifPresent(totalFlushFilteredRows::inc); | ||
Optional.ofNullable(responseContent.getLoadTimeMs()).ifPresent(totalFlushTimeMs::inc); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is getLoadTimeMs also a counter-type metric?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are two metric type for LoadTimeMs: Counter and Historgram ,
Thanks for the @vinlee19 . Can you post some final monitoring screenshots? |
Yeah,I will post the final monitoring screenshots later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Proposed changes
When you import data to Apache Doris in real time , you can observe the import of some metrics in Flink webui metrics. The metrics are a concatenation of table, and Flink metrics, e.g. table_1_totalFlushLoadBytes. Below is a description of how to use several metrics:
Problem Summary:
Describe the overview of changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...