-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improvement] fix some successfully precommitted cannot be aborted lead to LabelAlreadyExists #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JNSimba
changed the title
[improvement] add abort log
[improvement] fix some successfully precommitted cannot be aborted
Apr 10, 2024
JNSimba
changed the title
[improvement] fix some successfully precommitted cannot be aborted
[improvement] fix some successfully precommitted cannot be aborted lead to LabelAlreadyExists
Apr 10, 2024
CalvinKirs
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Problem Summary:
In the case of writing to multiple tables, such as tables A, B, and C, if tables D and E are added during the period (there is no streamloader for this table in the previous Checkpoint), in the precommit phase, if table D succeeds but table E fails, this will retry from the last Checkpoint, but there is no streamloader of table D in the last checkpoint, so the txn of table D that has been successfully precommitted cannot be aborted, and the error LabelAlreadyExists will be reported next time
In the scenario of writing to multiple tables, if the sink is multi-concurrent,
At this time, the A thread reports an error, and the B thread Http request has ended, and the txnid of successful precommit has not been obtained. However, when jobmanager tries to cancel thread B, the txnid of thread B may not be aborted in time, and an error labelAlreadExist will be reported next time.
Therefore, when the thread exits, it must be aborted according to the label (only available on doris 2.1+)
For example:
restore from ck-106
label107 alread exist,abort label107
label108 not use,abort fail
restore from ck-106
label107 not use,exit abort
label108 write,label already exists
At this time, you need to actively abort the label and let flink restart
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...