Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dubbo-admin #1213

Merged
merged 34 commits into from
Aug 14, 2023
Merged

fix dubbo-admin #1213

merged 34 commits into from
Aug 14, 2023

Conversation

sjmshsh
Copy link

@sjmshsh sjmshsh commented Aug 8, 2023

fix ci, fix bug, fix dds and add DdsGenerator

@sjmshsh sjmshsh changed the title fix dds fix dubbo-admin Aug 13, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2023

Codecov Report

Merging #1213 (e51c0ff) into refactor-with-go-components-experimental (d292375) will decrease coverage by 2.44%.
Report is 12 commits behind head on refactor-with-go-components-experimental.
The diff coverage is 49.84%.

@@                             Coverage Diff                              @@
##           refactor-with-go-components-experimental    #1213      +/-   ##
============================================================================
- Coverage                                     49.11%   46.68%   -2.44%     
============================================================================
  Files                                           113      113              
  Lines                                          6010     6439     +429     
  Branches                                         41       41              
============================================================================
+ Hits                                           2952     3006      +54     
- Misses                                         2802     3142     +340     
- Partials                                        256      291      +35     
Files Changed Coverage Δ
pkg/admin/model/util/sync_utils.go 22.60% <0.00%> (ø)
pkg/admin/services/generic_service_Impl.go 0.00% <0.00%> (ø)
pkg/admin/services/registry_service_sync.go 0.00% <0.00%> (-17.98%) ⬇️
pkg/admin/services/service_testing_v3.go 0.00% <0.00%> (ø)
pkg/admin/services/traffic/accesslog.go 0.00% <0.00%> (ø)
pkg/admin/services/traffic/argument.go 0.00% <0.00%> (ø)
pkg/admin/services/traffic/mock.go 0.00% <0.00%> (ø)
pkg/admin/services/traffic/region.go 0.00% <0.00%> (ø)
pkg/admin/services/traffic/retry.go 0.00% <0.00%> (ø)
pkg/admin/services/traffic/weight.go 0.00% <0.00%> (ø)
... and 28 more

... and 71 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Aug 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@FinalT FinalT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chickenlj chickenlj merged commit 8562ead into apache:refactor-with-go-components-experimental Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants