Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.1] Fix 3.1 circular dependency #10259

Merged
merged 4 commits into from
Jul 3, 2022
Merged

Conversation

AlbumenJ
Copy link
Member

@AlbumenJ AlbumenJ commented Jul 3, 2022

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented Jul 3, 2022

Codecov Report

Merging #10259 (34aacf8) into 3.1 (625dba6) will decrease coverage by 0.12%.
The diff coverage is 54.69%.

@@             Coverage Diff              @@
##                3.1   #10259      +/-   ##
============================================
- Coverage     65.71%   65.58%   -0.13%     
+ Complexity      320      319       -1     
============================================
  Files          1220     1234      +14     
  Lines         53140    53809     +669     
  Branches       8059     8120      +61     
============================================
+ Hits          34919    35293     +374     
- Misses        14408    14687     +279     
- Partials       3813     3829      +16     
Impacted Files Coverage Δ
.../rpc/cluster/router/state/RouterGroupingState.java 0.00% <0.00%> (ø)
...mmon/config/configcenter/DynamicConfiguration.java 64.70% <ø> (-1.97%) ⬇️
...fig/configcenter/TreePathDynamicConfiguration.java 65.62% <ø> (+5.62%) ⬆️
...nfig/configcenter/nop/NopDynamicConfiguration.java 25.00% <ø> (+2.77%) ⬆️
...gcenter/wrapper/CompositeDynamicConfiguration.java 69.23% <ø> (+1.73%) ⬆️
...apache/dubbo/common/constants/CommonConstants.java 100.00% <ø> (ø)
.../apache/dubbo/common/threadpool/MemoryLimiter.java 19.68% <0.00%> (+0.15%) ⬆️
...on/threadpool/support/cached/CachedThreadPool.java 90.00% <0.00%> (ø)
...mmon/threadpool/support/fixed/FixedThreadPool.java 87.50% <0.00%> (ø)
.../threadpool/support/limited/LimitedThreadPool.java 88.88% <0.00%> (ø)
... and 194 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f48fbd8...34aacf8. Read the comment docs.

@AlbumenJ AlbumenJ merged commit b5e7598 into apache:3.1 Jul 3, 2022
@AlbumenJ AlbumenJ added this to the 3.1.0 milestone Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants