Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RegistryDirectory deadlock #14454

Merged
merged 1 commit into from
Jul 21, 2024
Merged

Fix RegistryDirectory deadlock #14454

merged 1 commit into from
Jul 21, 2024

Conversation

oxsean
Copy link
Collaborator

@oxsean oxsean commented Jul 20, 2024

What is the purpose of the change

Dead lock when running unit test
image
image

2024-07-20T09:21:49.3536989Z [INFO] Running org.apache.dubbo.config.ConfigTest
2024-07-20T09:21:49.3538059Z [DubboTestChecker] Run test method: org.apache.dubbo.config.ConfigTest#testConfig
2024-07-20T09:21:49.4922706Z 09:21:49.344 |-INFO  [main] rg.apache.dubbo.rpc.model.FrameworkModel:71  -|  [DUBBO] Dubbo Framework[6] is created, dubbo version: 3.3.0-beta.5-SNAPSHOT, current host: 10.1.0.47
...
2024-07-20T09:21:52.2085345Z 09:21:52.129 |-INFO  [main] bbo.registry.multicast.MulticastRegistry:71  -|  [DUBBO] Notify urls for subscribe url consumer://10.1.0.47/org.apache.dubbo.service.DemoService?application=first-dubbo-test&background=false&category=providers,configurators,routers&dubbo=2.0.2&executor-management-mode=isolation&file-cache=false&interface=org.apache.dubbo.service.DemoService&methods=complexCompute,enumlength,findComplexObject,get,getSize,getThreadName,getbyte,invoke,sayHello,stringLength,timestamp&pid=245981&release=3.3.0-beta.5-SNAPSHOT&side=consumer&sticky=false&timestamp=1721467310480&unloadClusterRelated=false, url size: 1, dubbo version: 3.3.0-beta.5-SNAPSHOT, current host: 10.1.0.47
2024-07-20T10:29:19.1216300Z ##[error]The action 'Test with Maven with SonarCloud Scan' has timed out after 90 minutes.

Brief changelog

Skip notify if applicationModel destroyed

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

Copy link

sonarcloud bot commented Jul 21, 2024

@AlbumenJ AlbumenJ merged commit 2a42f4f into apache:3.3 Jul 21, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants