Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] add event listener framework for IcebergRESTServer #4958

Closed
Tracked by #5204
FANNG1 opened this issue Sep 19, 2024 · 0 comments · Fixed by #5002
Closed
Tracked by #5204

[Improvement] add event listener framework for IcebergRESTServer #4958

FANNG1 opened this issue Sep 19, 2024 · 0 comments · Fixed by #5002
Assignees
@FANNG1
Labels
0.7.0 Release v0.7.0 ICEBERG-REST-SERVER improvement Improvements on everything
Milestone
Gravitino 0.7.0

Comments

@FANNG1
Copy link
Contributor

FANNG1 commented Sep 19, 2024 •
edited
Loading

What would you like to be improved?

#2233 add the event listener system to Gravitino, we need to add Iceberg REST related event to event systems to facility Iceberg REST users to do custom operations.

How should we improve?

No response
@FANNG1 FANNG1 added improvement Improvements on everything ICEBERG-REST-SERVER labels Sep 19, 2024
@FANNG1 FANNG1 added this to the Gravitino 0.7.0 milestone Sep 19, 2024
@FANNG1 FANNG1 mentioned this issue Oct 16, 2024
Merged
@FANNG1 FANNG1 self-assigned this Oct 21, 2024
@FANNG1 FANNG1 added the 0.7.0 Release v0.7.0 label Oct 21, 2024
@FANNG1 FANNG1 changed the title [Improvement] add event listener support for IcebergRESTServer [Improvement] add event listener framework for IcebergRESTServer Oct 22, 2024
@FANNG1 FANNG1 mentioned this issue Oct 22, 2024
Open
4 tasks
This was referenced Nov 4, 2024
Open
Closed
mplmoknijb pushed a commit to mplmoknijb/gravitino that referenced this issue Nov 6, 2024
@FANNG1 @yuqi1129 @mplmoknijb
[4958] feat(iceberg): support event listener for Iceberg REST server (a…
429a4a2 
…pache#5002)

### What changes were proposed in this pull request?

1.   Integrate Event listener system to Iceberg REST server
2. only dispatch create table event like `CreateIcebergTableEvent`
`CreateIcebergTablePreEvent` `CreateIcebergTableFailureEvent`


### Why are the changes needed?

Fix: apache#4958 

### Does this PR introduce _any_ user-facing change?
no

### How was this patch tested?
1. add configuration to add `IcebergEventLogger`  in event listener
```
gravitino.eventListener.names = iceberg
gravitino.eventListener.iceberg.class = org.apache.gravitino.iceberg.extension.IcebergEventLogger
```
2. run query will see event logs.

---------

Co-authored-by: Qi Yu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FANNG1 FANNG1

Labels
0.7.0 Release v0.7.0 ICEBERG-REST-SERVER improvement Improvements on everything
Projects
None yet
Milestone
Gravitino 0.7.0
Development

Successfully merging a pull request may close this issue.

[4958] feat(iceberg): support event listener for Iceberg REST server FANNG1/gravitino
1 participant
@FANNG1