Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update windows define and accept snmp leaf #1379

Merged
merged 2 commits into from
Dec 4, 2023
Merged

update windows define and accept snmp leaf #1379

merged 2 commits into from
Dec 4, 2023

Conversation

jinyaoMa
Copy link
Contributor

@jinyaoMa jinyaoMa commented Dec 4, 2023

What's changed?

Checklist

  • I hereby agree to the terms of the HertzBeat CLA
  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

@tomsun28 tomsun28 added enhancement New feature or request good first pull request Good for newcomers labels Dec 4, 2023
@tomsun28 tomsun28 added this to the v1.4.3 milestone Dec 4, 2023
tomsun28
tomsun28 approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍👍

@tomsun28
Copy link
Contributor

tomsun28 commented Dec 4, 2023

@all-contributors please add @jinyaoMa for code

@allcontributors allcontributors bot mentioned this pull request Dec 4, 2023
Merged
@tomsun28 tomsun28 merged commit f636298 into apache:master Dec 4, 2023
2 checks passed
@allcontributors AllContributors
Copy link
Contributor

@tomsun28

I've put up a pull request to add @jinyaoMa! 🎉

tomsun28 pushed a commit that referenced this pull request Jan 16, 2024
@jinyaoMa @tomsun28
update windows define and accept snmp leaf (#1379)
e39f9cd
tomsun28 pushed a commit that referenced this pull request Mar 9, 2024
@jinyaoMa
update windows define and accept snmp leaf (#1379)
5c65bb8
tomsun28 pushed a commit that referenced this pull request Mar 9, 2024
@jinyaoMa
update windows define and accept snmp leaf (#1379)
097b589
tomsun28 pushed a commit that referenced this pull request Mar 10, 2024
@jinyaoMa
update windows define and accept snmp leaf (#1379)
0025ac2
tomsun28 pushed a commit that referenced this pull request Mar 10, 2024
@jinyaoMa @tomsun28
update windows define and accept snmp leaf (#1379)
de4b76e
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@jinyaoMa
update windows define and accept snmp leaf (#1379)
b3623b4
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@jinyaoMa
update windows define and accept snmp leaf (#1379)
ba07e9f
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@jinyaoMa
update windows define and accept snmp leaf (#1379)
ef16478
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@jinyaoMa
update windows define and accept snmp leaf (#1379)
d5cdccc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsun28 tomsun28 tomsun28 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request good first pull request Good for newcomers
Projects
None yet
Milestone
v1.4.3
Development

Successfully merging this pull request may close these issues.
2 participants
@jinyaoMa @tomsun28