Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

rename "topology master" to "topology manager"? #3622

Closed
armadillojim opened this issue Oct 24, 2020 · 2 comments
Closed

rename "topology master" to "topology manager"? #3622

armadillojim opened this issue Oct 24, 2020 · 2 comments

Comments

@armadillojim
Copy link
Contributor

Howdy! I'm relatively new to Heron, and it seems like a wonderful product. Thanks for all your hard work in developing it!

As a newbie I've been reading through the documentation. One thing caught my eye: the term "topology master". Other components don't use the same word. For example, there are the "metrics manager", "stream manager", and "zoo keeper".

If I submitted a PR to change "master" to "manager", would that be well received? Or would such a change not be welcome? I searched through all the issues and PRs but didn't see anything related. Forgive me if this conversation has already been hashed through. Also, FWIW I'm suggesting "manager" in place of "master" to keep with a word beginning with "m"; that way the abbreviation "TM" doesn't change. However, perhaps someone else could come up with a more appropriate suggestion.

@nicknezis
Copy link
Contributor

I think it's a good idea. I'd be willing to review your merge request and test it out.

@armadillojim
Copy link
Contributor Author

Thanks so much, @nicknezis! I just created #3624.

I haven't done testing yet as the edits took me much longer than I originally anticipated. However, I will try my best to do so over the next few days. Any suggestions are welcome!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants